eBay / flutter_glove_box

Various eBay tools for Flutter development
BSD 3-Clause "New" or "Revised" License
319 stars 68 forks source link

Support for Flutter Web #80

Open srix55 opened 3 years ago

srix55 commented 3 years ago

Currently this package is not compatible with web platform. Please consider adding support for flutter web. Thanks.

image

fatherOfLegends commented 3 years ago

@srix55 This is odd because the package is exclusively for testing. As a dev dependency it should work just fine in a flutter app that targets the web. Do you have a failing example or is it just the static analysis rule on pub.dev?

srix55 commented 3 years ago

@fatherOfLegends You are right. I haven't had any problems while running my tests. Just that I noticed that the package would not show up when I filtered by web in pub.dev. I guess the expectation is to have this show up as web compatible in pub as many users would think this won't work for apps targeting web, or might not see this package at all when filtering by platforms.

mZadorskii commented 3 years ago

dar io does not support web

On Thu, Nov 12, 2020 at 8:45 PM Larry McKenzie notifications@github.com wrote:

@srix55 https://github.com/srix55 This is odd because the package is exclusively for testing. As a dev dependency it should work just fine in a flutter app that targets the web. Do you have a failing example or is it just the static analysis rule on pub.dev?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eBay/flutter_glove_box/issues/80#issuecomment-726504783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDW7BP755LDPC57XZEWLVLSPS2VHANCNFSM4TUD5SIQ .

fatherOfLegends commented 3 years ago

@srix55 I agree with the discovery issue but I cannot think of a way around it. Do you have any ideas regarding how we could creatively resolve this?

fatherOfLegends commented 3 years ago

Here is an issue discussing this at length: https://github.com/dart-lang/pana/issues/720

srix55 commented 3 years ago

@fatherOfLegends Thanks for the update. I had a look at the flutter_test package code for half an hour and I am still pretty clueless about the fix...