acl add/delete code isn't handling external_ids correctly

eBay / go-ovn

A Go library for OVN Northbound/Southbound DB access using native OVSDB protocol

Apache License 2.0

108 stars 59 forks source link

acl add/delete code isn't handling external_ids correctly #124

Open anfredette opened 3 years ago

anfredette commented 3 years ago

external_ids should be ignored while checking for duplicates in ACLAdd and matching in ACLDel

The parameters that define a unique ACL for a given entity (logical switch or port group) are direction, match, and priority. The code currently also attempts to also use external_ids, but it should not.

anfredette commented 3 years ago

I updated the description based on a discussion with @hzhou8 on the desired behavior.