search

eBay / go-ovn

A Go library for OVN Northbound/Southbound DB access using native OVSDB protocol
Apache License 2.0
108 stars 59 forks source link

better developer experience: ability to run tests inside docker containers #126

Open vjayaramrh opened 3 years ago

vjayaramrh commented 3 years ago

The goal of this PR is to allow for developers (running on non linux systems such as MacBook and who do not have ovs/ovn installed) to be be able to run the tests in containers instead. The PR creates a Dockerfile based off the openvswitch/ovn:2.12_e60f2f2_debian_master base image and adds go binaries. It also installs supervisord to help with running ovn-nb, ovn-sb and ovn-northd in the same container. (Refer http://supervisord.org/introduction.html)

Note: I have an enhancement request in the ovn-org/ovn repo requesting that official docker images for each of the OVN release to quay/docker repo (refer https://github.com/ovn-org/ovn/issues/67)

vjayaramrh commented 3 years ago

Thanks @vjayaramrh It seems the #121 is addressing the problem in a similar way. Could you take a look? Please also see my comments.

@hzhou8 appreciate you pointing this out, I have reached out to the PR author to have an initial discussion and look at ways for combining our efforts

amorenoz commented 3 years ago

@vjayaramrh I think there are some interesting ideas here. Using a pre-built image would definitely improve the developer experience.

For now, the container does build ovn, only ovs (for the ovsdb-server). The compatibility matrix with ovsdb should be relatively straight forward. But that might change as a result of the discussions in #29. So, when those discussions clear out the go-ovn -> ovn compatibility strategy looking forward, we could improve the current system by using pre-built images. wdyt?

vpickard commented 3 years ago

cc @vpickard