eBay / nice-dag

nice-dag is a lightweight javascript library, which is used to present a DAG diagram.
https://opensource.ebay.com/nice-dag/examples/index.html
MIT License
49 stars 18 forks source link

nice-dag-vue3 and nice-dag-react published to npmjs contain workspace dependencies #37

Open eldjh3 opened 6 months ago

eldjh3 commented 6 months ago

Issue

The workspace dependencies on nice-dag-core from the vue3/react packages are not resolved in the published packages. For example, at https://www.npmjs.com/package/@ebay/nice-dag-vue3?activeTab=code the dependencies appear as follows:

  "dependencies": {
    "vite-plugin-dts": "^1.6.6",
    "vue": "^3.2.38",
    "@ebay/nice-dag-core": "workspace:^"    <-- Here
  }

If I run pnpm pack on a local working copy of the git repo, it gets resolved as expected.

  "dependencies": {
    "vite-plugin-dts": "^1.6.6",
    "vue": "^3.2.38",
    "@ebay/nice-dag-core": "^1.0.33"
  }

The published versions fail when you try and install them as dependencies in a project as they are expecting to find a @ebay/nice-dag-core workspace.

How to Reproduce

  1. Create a project
  2. Attempt to add @ebay/nice-dag-vue3 (or @ebay/nice-dag-react) as a dependency npm install @ebay/nice-dag-vue3
  3. It will fail with errors regarding an unrecognised URL type. yarn and pnpm fail with slightly different errors.
eldjh3 commented 6 months ago

Looks like 1.0.21 is the first vue3 version affected and 1.0.31 for react.