search

eBay / nice-modal-react

A modal state manager for React.
https://ebay.github.io/nice-modal-react
MIT License
1.96k stars 110 forks source link

Source map references file not in npm package #108

Closed qidydl closed 1 year ago

qidydl commented 1 year ago

The just-released version 1.2.9 added source mapping, but the source map references a file that isn't included in the published package. This results in an error like the following:

WARNING in ./node_modules/@ebay/nice-modal-react/lib/esm/index.js
Module Warning (fom ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '<path>\node_modules\@ebay\nice-modal-react\src\index.tsx' file: Error: ENOENT: no such file or directory, open '<path>\node_modules\@ebay\nice-modal-react\src\index.tsx'

(I had to retype this message by hand for unrelated reasons so apologies if I typoed anything)

This doesn't appear to actually break anything, so it's probably a low-priority error, but the source map likely doesn't work.

mariuszubryt commented 1 year ago

I just did an upgrade to the new version and can confirm the same error message. However, I haven't noticed it breaking anything.

kbzowski commented 1 year ago

+1

supnate commented 1 year ago

Resolved in the latest version1.2.10.