Hot module reloading / fast refresh support?

eBay / nice-modal-react

A modal state manager for React.

https://ebay.github.io/nice-modal-react

MIT License

1.96k stars 109 forks source link

Hot module reloading / fast refresh support? #117

Closed ewalti closed 1 year ago

ewalti commented 1 year ago

I'm working on an older project that uses HMR. I find that if I have a modal open and I make an update to the code, everything else HMRs correctly, but the modal is stuck in time until I close it an re-open it. I tried using the declarative syntax as well to no avail. Is this just an issue with HMR? Would upgrading to fast refresh fix this? Does anyone else have this issue?

fobos531 commented 5 months ago

Hello @ewalti , did you ever find a solution to this? I'm experiencing a similar issue, however what I'm experiencing is that the change in the modal refreshes the entire page.

supnate commented 5 months ago

@fobos531 can you show your usage? NiceModal shouldn't break HMR.