search

eBay / nice-modal-react

A modal state manager for React.
https://ebay.github.io/nice-modal-react
MIT License
1.96k stars 110 forks source link

perf: improve type declaration hinting #68

Closed SevenOutman closed 1 year ago

SevenOutman commented 2 years ago

Give default export a name so that editors can give users hints when they try to import "NiceModal".

image
codecov-commenter commented 2 years ago

Codecov Report

Merging #68 (81d55b6) into main (22a6a4e) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          185       186    +1     
  Branches        29        29           
=========================================
+ Hits           185       186    +1
Impacted Files Coverage Δ
src/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22a6a4e...81d55b6. Read the comment docs.

supnate commented 1 year ago

Nice! Thanks @SevenOutman !