perf: improve type inference for NiceModal.show

eBay / nice-modal-react

A modal state manager for React.

https://ebay.github.io/nice-modal-react

MIT License

1.96k stars 110 forks source link

Closed SevenOutman closed 1 year ago

SevenOutman commented 2 years ago

Let NiceModal.show infer the props type from the modal component it receives.

Close #67

supnate commented 1 year ago

Thanks @SevenOutman ! This looks also be addressed in https://github.com/eBay/nice-modal-react/pull/70 , I will take a look later!

SevenOutman commented 1 year ago

Hi @supnate, would you mind publishing a new release soon so that users can receive the latest changes?