search

eBay / nice-modal-react

A modal state manager for React.
https://ebay.github.io/nice-modal-react
MIT License
1.96k stars 110 forks source link

Rename id to modalId #96

Closed osrl closed 1 year ago

osrl commented 1 year ago

NiceModalHocProps has a field named id. This is too common and prevents us to pass a type with id on it. I've changed it to modalId which is more convenient IMHO.

osrl commented 1 year ago

This is not backward compatible. It's too much work for a simple renaming issue. I'm closing the pr