codecov-commenter
commented
8 months ago Codecov Report
Attention: 59 lines in your changes are missing coverage. Please review.
Comparison is base (
8066124) 77.07% compared to head (ebd94dd) 74.51%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================== - Coverage 77.07% 74.51% -2.57% ========================================== Files 20 19 -1 Lines 820 769 -51 Branches 91 90 -1 ========================================== - Hits 632 573 -59 - Misses 132 137 +5 - Partials 56 59 +3 ``` | [Files](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay) | Coverage Δ | | |---|---|---| | [src/lib/manager\_impl.hpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9tYW5hZ2VyX2ltcGwuaHBw) | `50.00% <ø> (ø)` | | | [src/lib/mesg\_factory.cpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9tZXNnX2ZhY3RvcnkuY3Bw) | `90.00% <100.00%> (ø)` | | | [src/lib/grpc\_factory.cpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9ncnBjX2ZhY3RvcnkuY3Bw) | `74.31% <0.00%> (ø)` | | | [src/lib/common\_lib.hpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9jb21tb25fbGliLmhwcA==) | `0.00% <0.00%> (ø)` | | | [src/lib/manager\_impl.cpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9tYW5hZ2VyX2ltcGwuY3Bw) | `72.78% <65.33%> (-7.13%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/46/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
No API changes.
This just removes some of the clutter left from merging nuraft_grpc with sds_messaging and prepares for easier optional FlatBuffers serialization code path (while retaining Protobuf).
I also improved the logging and fixed a couple race issues in the UTs.