eBay / nuraft_mesg

A session management and gRPC service layer for NuRaft.
Apache License 2.0
6 stars 11 forks source link

Remove confusing indirection. #49

Closed szmyd closed 10 months ago

codecov-commenter commented 10 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (d7e3366) 73.70% compared to head (d05d090) 75.73%. Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ========================================== + Coverage 73.70% 75.73% +2.03% ========================================== Files 21 21 Lines 848 812 -36 Branches 96 95 -1 ========================================== - Hits 625 615 -10 + Misses 164 134 -30 - Partials 59 63 +4 ``` | [Files](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay) | Coverage Δ | | |---|---|---| | [src/include/nuraft\_mesg/mesg\_factory.hpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2luY2x1ZGUvbnVyYWZ0X21lc2cvbWVzZ19mYWN0b3J5LmhwcA==) | `100.00% <100.00%> (ø)` | | | [src/include/nuraft\_mesg/mesg\_state\_mgr.hpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2luY2x1ZGUvbnVyYWZ0X21lc2cvbWVzZ19zdGF0ZV9tZ3IuaHBw) | `100.00% <ø> (ø)` | | | [src/include/nuraft\_mesg/nuraft\_mesg.hpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2luY2x1ZGUvbnVyYWZ0X21lc2cvbnVyYWZ0X21lc2cuaHBw) | `100.00% <ø> (ø)` | | | [src/lib/factory.cpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9mYWN0b3J5LmNwcA==) | `74.31% <ø> (ø)` | | | [src/lib/manager\_impl.hpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9tYW5hZ2VyX2ltcGwuaHBw) | `0.00% <ø> (-50.00%)` | :arrow_down: | | [src/lib/proto/proto\_client.cpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9wcm90by9wcm90b19jbGllbnQuY3Bw) | `90.69% <ø> (ø)` | | | [src/lib/repl\_service\_ctx.hpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9yZXBsX3NlcnZpY2VfY3R4LmhwcA==) | `100.00% <100.00%> (ø)` | | | [src/lib/service.hpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9zZXJ2aWNlLmhwcA==) | `0.00% <ø> (-25.00%)` | :arrow_down: | | [src/lib/proto/proto\_service.cpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9wcm90by9wcm90b19zZXJ2aWNlLmNwcA==) | `71.23% <93.54%> (ø)` | | | [src/lib/repl\_service\_ctx.cpp](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay#diff-c3JjL2xpYi9yZXBsX3NlcnZpY2VfY3R4LmNwcA==) | `91.66% <91.66%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/eBay/nuraft_mesg/pull/49/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eBay)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.