eBay / nvidiagpubeat

nvidiagpubeat is an elastic beat that uses NVIDIA System Management Interface (nvidia-smi) to monitor NVIDIA GPU devices and can ingest metrics into Elastic search cluster, with support for both 6.x and 7.x versions of beats. nvidia-smi is a command line utility, based on top of the NVIDIA Management Library (NVML), intended to aid in the management and monitoring of NVIDIA GPU devices.
https://github.com/eBay/nvidiagpubeat
Apache License 2.0
54 stars 22 forks source link

Any plans to make this compatible with 7.x? #18

Closed highjynks closed 5 years ago

highjynks commented 5 years ago

Using nvidiagpubeat, installed as per docs. Elasticsearch instance is version 7.1 It's my understanding that in 7.0, they no longer allow doctype support, it's one of the breaking changes from 6.0. I could be wrong. Here's the output I get when gpubeat tries to install the template on ES:

2019-06-04T13:11:35.674-0700 DEBUG [elasticsearch] elasticsearch/client.go:731 PUT https://es:9200/_template/nvidiagpubeat-6.5.5 map[settings:{"index":{"mapping":{"total_fields":{"limit":10000}},"number_of_routing_shards":30,"query":{"default_field":["fields.*"]},"refresh_interval":"5s"}} index_patterns:[nvidiagpubeat-6.5.5-*] mappings:{"doc":{"_meta":{"version":"6.5.5"},"date_detection":false,"dynamic_templates":[{"strings_as_keyword":{"mapping":{"ignore_above":1024,"type":"keyword"},"match_mapping_type":"string"}}],"properties":{}}} order:1] 2019-06-04T13:11:35.680-0700 ERROR pipeline/output.go:100 Failed to connect to backoff(elasticsearch(https://es:9200)): Connection marked as failed because the onConnect callback failed: Error loading Elasticsearch template: could not load template. Elasticsearch returned: couldn't load template: couldn't load json. Error: 400 Bad Request: {"error":{"root_cause":[{"type":"mapper_parsing_exception","reason":"Root mapping definition has unsupported parameters: [doc : {_meta={version=6.5.5}, dynamic_templates=[{strings_as_keyword={mapping={ignore_above=1024, type=keyword}, match_mapping_type=string}}], properties={}, date_detection=false}]"}],"type":"mapper_parsing_exception","reason":"Failed to parse mapping [_doc]: Root mapping definition has unsupported parameters: [doc : {_meta={version=6.5.5}, dynamic_templates=[{strings_as_keyword={mapping={ignore_above=1024, type=keyword}, match_mapping_type=string}}], properties={}, date_detection=false}]","caused_by":{"type":"mapper_parsing_exception","reason":"Root mapping definition has unsupported parameters: [doc : {_meta={version=6.5.5}, dynamic_templates=[{strings_as_keyword={mapping={ignore_above=1024, type=keyword}, match_mapping_type=string}}], properties={}, date_detection=false}]"}},"status":400}. Response body: {"error":{"root_cause":[{"type":"mapper_parsing_exception","reason":"Root mapping definition has unsupported parameters: [doc : {_meta={version=6.5.5}, dynamic_templates=[{strings_as_keyword={mapping={ignore_above=1024, type=keyword}, match_mapping_type=string}}], properties={}, date_detection=false}]"}],"type":"mapper_parsing_exception","reason":"Failed to parse mapping [_doc]: Root mapping definition has unsupported parameters: [doc : {_meta={version=6.5.5}, dynamic_templates=[{strings_as_keyword={mapping={ignore_above=1024, type=keyword}, match_mapping_type=string}}], properties={}, date_detection=false}]","caused_by":{"type":"mapper_parsing_exception","reason":"Root mapping definition has unsupported parameters: [doc : {_meta={version=6.5.5}, dynamic_templates=[{strings_as_keyword={mapping={ignore_above=1024, type=keyword}, match_mapping_type=string}}], properties={}, date_detection=false}]"}},"status":400}. Template is: map[mappings:{"doc":{"_meta":{"version":"6.5.5"},"date_detection":false,"dynamic_templates":[{"strings_as_keyword":{"mapping":{"ignore_above":1024,"type":"keyword"},"match_mapping_type":"string"}}],"properties":{}}} order:%!s(int=1) settings:{"index":{"mapping":{"total_fields":{"limit":10000}},"number_of_routing_shards":30,"query":{"default_field":["fields.*"]},"refresh_interval":"5s"}} index_patterns:[nvidiagpubeat-6.5.5-*]]

deepujain commented 5 years ago

Verified your PR https://github.com/eBay/nvidiagpubeat/pull/19 and it works in MacOS + ES 7.2

  1. What are you plans for users with < ES 7.x . The PR would break users on < ES 7.x
deepujain commented 5 years ago

Now compatible with 7.x

Fix: https://github.com/eBay/nvidiagpubeat/pull/22 Documentation: https://github.com/eBay/nvidiagpubeat#nvidiagpubeat-and-beats-compatibility

Thank you for fix, suggestions.