search

eBay / parallec

Fast Parallel Async HTTP/SSH/TCP/UDP/Ping Client Java Library. Aggregate 100,000 APIs & send anywhere in 20 lines of code. Ping/HTTP Calls 8000 servers in 12 seconds. (Akka) www.parallec.io
Apache License 2.0
805 stars 173 forks source link

General code quality fix-2 #29

Closed faisal-hameed closed 8 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1488 - Local Variables should not be declared and then immediately returned or thrown. squid:S1640- Maps with keys that are enum values should be replaced with EnumMap. squid:S1319 - Declarations should use Java collection interfaces such as "List" rather than specific implementation. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1488 https://dev.eclipse.org/sonar/rules/show/squid:S1640 https://dev.eclipse.org/sonar/rules/show/squid:S1319

Please let me know if you have any questions.

Faisal Hameed

codecov-io commented 8 years ago

Current coverage is 93.52%

Merging #29 into master will decrease coverage by -0.02% as of 630772f

@@            master     #29   diff @@
======================================
  Files           80      80       
  Stmts         3082    3071    -11
  Branches       285     285       
  Methods          0       0       
======================================
- Hit           2883    2872    -11
  Partial         98      98       
  Missed         101     101

Review entire Coverage Diff as of 630772f

Powered by Codecov. Updated on successful CI builds.