search

eBay / parallec

Fast Parallel Async HTTP/SSH/TCP/UDP/Ping Client Java Library. Aggregate 100,000 APIs & send anywhere in 20 lines of code. Ping/HTTP Calls 8000 servers in 12 seconds. (Akka) www.parallec.io
Apache License 2.0
805 stars 173 forks source link

Code quality fix - Conditions should not unconditionally evaluate to "TRUE" or to "FALSE". #30

Closed faisal-hameed closed 8 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S2583 - Conditions should not unconditionally evaluate to "TRUE" or to "FALSE". You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2583

Please let me know if you have any questions.

Faisal Hameed

codecov-io commented 8 years ago

Current coverage is 93.51%

Merging #30 into master will decrease coverage by -0.03% as of ca73032

@@            master     #30   diff @@
======================================
  Files           80      80       
  Stmts         3082    3082       
  Branches       285     285       
  Methods          0       0       
======================================
- Hit           2883    2882     -1
+ Partial         98      94     -4
- Missed         101     106     +5

Review entire Coverage Diff as of ca73032

Powered by Codecov. Updated on successful CI builds.

jeffpeiyt commented 8 years ago

we prefer to preserve those null pointer exception checking. I believe it is different from the rule.

Thanks @faisal-hameed for your consideration