Code quality fix - Dead stores should be removed.

eBay / parallec

Fast Parallel Async HTTP/SSH/TCP/UDP/Ping Client Java Library. Aggregate 100,000 APIs & send anywhere in 20 lines of code. Ping/HTTP Calls 8000 servers in 12 seconds. (Akka) www.parallec.io

Apache License 2.0

805 stars 173 forks source link

Code quality fix - Dead stores should be removed. #32

Closed faisal-hameed closed 8 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1854 - Dead stores should be removed. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1854

Please let me know if you have any questions.

Faisal Hameed

codecov-io commented 8 years ago

Current coverage is 93.08%

Merging #32 into master will decrease coverage by 0.20%

@@             master        #32   diff @@
==========================================
  Files            80         80          
  Lines          3100       3093     -7   
  Methods           0          0          
  Messages          0          0          
  Branches        286        286          
==========================================
- Hits           2892       2879    -13   
- Misses          111        116     +5   
- Partials         97         98     +1

Powered by Codecov. Last updated by 8b5eabd...60bef0b

jeffpeiyt commented 8 years ago

Have some concerns on the local variable init, close it now but we may continue to discuss offline. Thanks so much @faisal-hameed for your check and help!