search

eBay / parallec

Fast Parallel Async HTTP/SSH/TCP/UDP/Ping Client Java Library. Aggregate 100,000 APIs & send anywhere in 20 lines of code. Ping/HTTP Calls 8000 servers in 12 seconds. (Akka) www.parallec.io
Apache License 2.0
805 stars 173 forks source link

Code quality fix - "public static" fields should be constant #33

Closed faisal-hameed closed 8 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1444 - "public static" fields should be constant You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1444

Please let me know if you have any questions.

Faisal Hameed

codecov-io commented 8 years ago

Current coverage is 93.45%

Merging #33 into master will decrease coverage by -0.09% as of f906613

@@            master     #33   diff @@
======================================
  Files           80      80       
  Stmts         3082    3042    -40
  Branches       285     285       
  Methods          0       0       
======================================
- Hit           2883    2843    -40
  Partial         98      98       
  Missed         101     101

Review entire Coverage Diff as of f906613

Powered by Codecov. Updated on successful CI builds.

jeffpeiyt commented 8 years ago

@faisal-hameed thank you for your effort. Let me review the changes this weekend.

jeffpeiyt commented 8 years ago

hi, we will need to change some of these config fields to be none static as they are intended to be changed by users to overwrite.