search

eBay / restcommander

Fast Parallel Async HTTP client as a Service to monitor and manage 10,000 web servers. (Java+Akka)
Apache License 2.0
900 stars 132 forks source link

Fixed typographical error, changed architechture to architecture in README. #14

Closed orthographic-pedant closed 8 years ago

orthographic-pedant commented 8 years ago

@eBay, I've corrected a typographical error in the documentation of the restcommander project. You should be able to merge this pull request automatically. However, if this was intentional or if you enjoy living in linguistic squalor, please let me know and create an issue on my home repository.

jeffpeiyt commented 8 years ago

Thanks orthographic-pedant for your contribution. Thanks!

jeffpeiyt commented 8 years ago

somehow I cannot merge them as the repo you come from is gone. I will make the change directly

thoppe commented 8 years ago

@jeffpeiyt That's interesting. I delete the repo as soon as the pull request is made. A few hundred other people have been able to make the merge successfully and yet and handle of them, like yourself, have this problem. If you have any insight into this please open up an issue!

thoppe commented 8 years ago

I think I see the problem. It happens if the issue is closed before a merge. Since the goal is to serve as a public service anyways, I'm OK if I don't get the commit record. Thanks!

jeffpeiyt commented 8 years ago

@thoppe Thanks Travis again for your support! We are planning a release of Commander as a core library in a month with almost 50% rewriting code and tons of new features, plus 85%+ test coverage. Most importantly with the new library we restructure it so that ebay/internal are no longer two branches. We learned a lot from the experience. Will keep you posted on the new one :-)