eBay / skin-react

Skin components built with React (Typescript)
https://ebay.github.io/skin-react/
MIT License
18 stars 12 forks source link

Feature/dialog component #27

Closed montoya332 closed 3 years ago

montoya332 commented 3 years ago

Dialog #1082 The dialog module has also been broken up into several modules:

Fullscreen Dialog https://github.com/eBay/ebayui-core/tree/7.0.0/src/components/ebay-fullscreen-dialog Lightbox Dialog https://github.com/eBay/ebayui-core/tree/7.0.0/src/components/ebay-lightbox-dialog Panel Dialog https://github.com/eBay/ebayui-core/tree/7.0.0/src/components/ebay-panel-dialog

These three modules complement the two other pre-existing dialogs:

Drawer Dialog Toast Dialog Interesting fact: Toast dialog is currently the only non-modal dialog.

Over the past several releases we have worked hard to close the gap on dialog structural differences between DS4 and DS6. In this release, all dialog header structure & layout has been consolidated under a single system (#1171). Please refer to the Skin website to view markup requirements.

The mini-lightbox dialog underwent a minor structural change. The close button was moved before the title in the DOM. This ensures a better reading order for assistive technology (#1261).