search

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
179 stars 67 forks source link

BUG: DS6 dialog selector is not specific enough #115

Closed seangates closed 6 years ago

seangates commented 6 years ago

Even using a scoped selector we still run into an issue with the specificity when DS6 dialog is used on a DS4 page. In other words, the current selector for DS4 is more specific than the DS6 selector. This means we will have issues when using scoped CSS.

Example

// scoped ds6 selector for the dialog
.ds6 dialog {
    ...
}

// DS4 selector
.dialog[role="dialog"] {
    ...
}

Screenshot

scoped CSS selector specificity

Reported by @CestDiego

ianmcburnie commented 6 years ago

Good spot, but shouldn't this go in https://github.com/eBay/skin/pull/113?

DylanPiercey commented 6 years ago

Probably should have [role="dialog"] on there anyways. I can fix that and update my PR.

seangates commented 6 years ago

@ianmcburnie Doh!

Let me close this and move it.