Combo: Remove iconfont and icon dependencies

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

https://ebay.github.io/skin/

MIT License

178 stars 67 forks source link

Combo: Remove iconfont and icon dependencies #13

Closed ianmcburnie closed 6 years ago

ianmcburnie commented 7 years ago

Skin is moving away from icon fonts towards SVG. When the time is right, we should remove icon and iconfont modules out of the combo bundle, as we do not want to continue promoting the icon font.

This will be a breaking change for skin-inception though.

I wonder whether we should just retire the combo bundle altogether. I know inception uses it, but I'm not entirely sure I see the benefit anymore of this bundle...

https://ebay.github.io/skin/#bundles

seangates commented 6 years ago

@ianmcburnie Is this still useful? Should we close it given the way we've done icons for DS6?

ianmcburnie commented 6 years ago

I think we can close this now. Closing.