search

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
178 stars 67 forks source link

phone-input: NEW module (listbox-button + textbox) #1601

Closed randybascue closed 6 months ago

randybascue commented 2 years ago

We have updated the styling of the phone number entry field to appear as a single input field.

Variants

Properties

randybascue commented 2 years ago

image

randybascue commented 2 years ago

image

agliga commented 2 years ago

Nice to have. Most teams have their own component already.

ArtBlue commented 2 years ago

This looks to need more details as the interactivity isn't that clear. I'm assuming this will also be a component in ebay ui, so these things need to be defined. Some (or all?) may need be needed for this issue, at least insofar as specifications and assets are concerned.

  1. Do we have all the country flag svg files?
  2. What happens when the country selection is made from the dropdown? Would the country flag populate/replace the US flag?
  3. Would the phone number prefix (+1 for US) also change based on country selection change? If so, do we have those corresponding codes list somewhere?
agliga commented 2 years ago

Spoke to design yesterday. This is not high priority and we can punt till next release.

What we probably will do is have a way for teams to have a dropdown on textbox and they can populate it with what they want. That is unless design has other ideas and they can provide us with all this info

randybascue commented 1 year ago

I didn’t realize this was still on the backlog. This is getting increased interest. Any chance to reprioritize?

ianmcburnie commented 1 year ago

Do we have all the country flag svg files?

randybascue commented 1 year ago

I have a fully converted and optimized library, pulled from an open-source repo.

ianmcburnie commented 1 year ago

Allllright!!! Thanks! Created separate task for those: https://github.com/eBay/skin/issues/2184

randybascue commented 1 year ago

Creating detailed specs in this branch