Closed ianmcburnie closed 11 months ago
Even if we can’t make the full change yet, we should definitely update the [dir=rtl]
attribute selector to instead use the dedicated :dir()
pseudo-class, for more robust behavior when nesting dir
changes.
Even if we can’t make the full change yet, we should definitely update the
[dir=rtl]
attribute selector to instead use the dedicated:dir()
pseudo-class, for more robust behavior when nestingdir
changes.
Browser compatibility doesn't look so hot: https://developer.mozilla.org/en-US/docs/Web/CSS/:dir#browser_compatibility
Ah, damn. I must have confused its browser support with :lang()
’s instead.
With our recent browser policy update, I believe we can start leveraging CSS Logical Properties. This will allow us to do away with the current approach of using
[dir=rtl]
selector.https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Logical_Properties
Example of current code that can be refactored: https://github.com/eBay/skin/blob/master/src/less/button/button.less#L460
As a side note, it's probably going to take a little while getting used to these!!!