search

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
178 stars 67 forks source link

ebay-lightbox-dialog: standard sizes #1937

Closed randybascue closed 1 year ago

randybascue commented 1 year ago

We are standardizing the sizes available for ebay-lightbox-dialog. We want to provide two sizes, a regular 616px and a wide 896px. Both are fixed until they reach 100% of the grid width. Once they reach 100% they pin to the left and right. We also want to add a minimum height of 280px and max height of 90% of screen/window height.

DOD: Modals are available in two sizes: a regular 616px and a wide 896px. Min-width is set to 280px.

Documentation preview

image

Responsive animation

https://user-images.githubusercontent.com/35155833/201787773-3fd4cd6d-8f78-4ac9-9c87-90d139561930.mov

ArtBlue commented 1 year ago

This issue appears to have conflicts with https://github.com/eBay/skin/issues/1874.

agliga commented 1 year ago

Possible breaking. Need to investigate @ArtBlue

randybascue commented 1 year ago

@agliga Will the update to the scrolling behavior be a part of this as well?

agliga commented 1 year ago

@agliga Will the update to the scrolling behavior be a part of this as well?

Yes