search

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
178 stars 67 forks source link

ebay-listbox-button: update enabled border #1977

Closed randybascue closed 1 year ago

randybascue commented 1 year ago

The library had the listbox button border set to color-border-subtle, and Storybook appears to have it using color-border-strong. To improve visibility and consistency, this needs to be updated to use color-border-default. The active state will continue using color-border-strong.

Previous

image

Updated

image

agliga commented 1 year ago

Will only do this one for non form styling.

agliga commented 1 year ago

Closing, this appears to be fixed already.

Screenshot 2023-09-13 at 10 49 28 AM

https://github.com/eBay/skin/blob/master/src/less/mixins/private/dropdown-mixins.less#L5 (its using color-stroke-default)