ebay-button: fix button title on hover/focus

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

https://ebay.github.io/skin/

MIT License

178 stars 67 forks source link

ebay-button: fix button title on hover/focus #1983

Closed randybascue closed 1 year ago

randybascue commented 1 year ago

The design system darkens the button fill and the button title at the same rate using a state-layer scrim above the content. Currently, various Jira tix are flagging the button title as failing contrast on hover/focus. This indicates that the title is not darkening as it should.

Problem: button titles are failing contrast on hover/focus.

Solution: apply the proper darkening algorithm.

randybascue commented 1 year ago

Current implementation:

Correct implementation

randybascue commented 1 year ago

eBay / skin

ebay-button: fix button title on hover/focus #1983

Current implementation:

Correct implementation

Isometric view of button and state layer