search

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
178 stars 67 forks source link

textbox: add blue focus indicator #2089

Closed ArtBlue closed 1 year ago

ArtBlue commented 1 year ago

Currently, using textbox with other form controls creates an inconsistent focus experience - textbox does not have the blue focus outline like other controls.

For this issue, add the blue focus indicator like the one on select for form control focus consistency.

image

agliga commented 1 year ago

Is this as per design? I know we change the border color when we focus on textbox. We should be consistent but also check with design. We have it explicity set as 0 in the code https://github.com/eBay/skin/blob/master/src/less/textbox/textbox.less#L135 It could be legacy but it could be intentional (its hard to tell from the history).