toast: secondary action has unreadable text on hover

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

https://ebay.github.io/skin/

MIT License

178 stars 67 forks source link

toast: secondary action has unreadable text on hover #2092

Closed PrashantAshok closed 1 year ago

PrashantAshok commented 1 year ago

Screen Shot 2023-07-07 at 1 42 04 PM

Repro: https://opensource.ebay.com/skin/#toast-dialog

randybascue commented 1 year ago

@ArtBlue @LuLaValva how are these buttons being styled currently? We should either create a button variant explicitly labeled something like "white" or "on-color", or apply the color-foreground-on-{color} tokens here.

LuLaValva commented 1 year ago

Right now we are overriding the colors specifically for buttons that are inside toast dialog to these values, but it looks like this is a case that we didn't take into account. I wasn't able to find this component in Figma, would you mind pointing me in the right direction @randybascue?