eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
176 stars 66 forks source link

230810 - Item tile framework and components #2133

Open ratinsl opened 1 year ago

ratinsl commented 1 year ago
230810_Item_Tiles

DS has constructed a new item tile framework and would like to partner with the skin team in building out item tile components. Below you will find links to the KO item tile framework deck we shared, as well as the updated documentation page.

Please reach out to Jeremy and I with any questions.

Best, Ryan

agliga commented 7 months ago

Need to verify if we can use grid layout to align the title and price elements.

ArtBlue commented 4 months ago

I verified that display: grid can be used with grid-template-areas "cells" to accomplish the layout. The most flexible layout appears to be an outer flex for the item tiles and a grid display for each item tile.

The solution will involve something along the lines of:

grid-template-rows: auto 25px 60px 1fr;
grid-template-areas:
    "image"
    "signal"
    "title"
    "highlight";

image

ArtBlue commented 3 months ago

@ratinsl , I'm punting this for now. The DS specs are not feasible in some instances and they generally need to be more responsive-centric and less pixel-prescriptive. We can discuss offline.

ArtBlue commented 1 month ago

Hey, @ratinsl , to start this issue, we'll need the number of item tiles to display per row before wrapping to next line. Once those specs are defined, we can start this. This is related to the discussion we had previously about responsive elements that repeat. The minimum and maximum widths of the item tiles should also not block the item tiles from being fluid enough with the rules you put in place.

randybascue commented 1 month ago

I'm assuming we can update the specs to match the toggle button. I can try helping there.

ArtBlue commented 1 month ago

I'm assuming we can update the specs to match the toggle button. I can try helping there.

Thanks, @randybascue . Yes, it would be similar to what you did with toggle-button-group.