ebay-signal has incorrect type size and internal padding.

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

https://ebay.github.io/skin/

MIT License

178 stars 67 forks source link

ebay-signal has incorrect type size and internal padding. #2212

Closed Kevibrown closed 7 months ago

Kevibrown commented 9 months ago

I verified there's no existing issue for this bug.

[X] There are no existing issues

Current behavior

Storybook component has 12px and it should be 10px with 12px line height.

Internal padding does not align to Figma spec.

Spec

Expected behavior

No response

Skin version

No response

Device/OS/Browser info

No response

Steps to reproduce

1.
2.
3.
...

Relevant code block

No response

Additional context

No response

ArtBlue commented 7 months ago

Technically, this is not a bug, but a misalignment of the spec. The Figma was likely updated since the last Skin update.

Kevibrown commented 7 months ago

Good point, is there a better classification you'd prefer for these types of instances in the future?

ArtBlue commented 7 months ago

Good point, is there a better classification you'd prefer for these types of instances in the future?

@Kevibrown , unfortunately, at this point, no one would have a way of knowing whether it's truly a bug or a Figma misalignment. DS has been working on creating versioning and status indicators that should help, but I'm not sure when that's going to roll out. I'm afraid for now, this is the best we can do.