listbox-button: listbox option text is truncated to width of button

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

https://ebay.github.io/skin/

MIT License

178 stars 67 forks source link

listbox-button: listbox option text is truncated to width of button #2214

Closed LuLaValva closed 10 months ago

LuLaValva commented 11 months ago

I verified there's no existing issue for this bug.

[X] There are no existing issues

Current behavior

Font Size story shows truncated text.

Expected behavior

Text should not be truncated.

Skin version

16.9.0

Device/OS/Browser info

MacOS, Google Chrome

Steps to reproduce

Visit [font size story](https://opensource.ebay.com/skin/storybook/?path=/story/skin-listbox-button-cascade--font-size)

Relevant code block

No response

Additional context

No response

ArtBlue commented 10 months ago

I'm not convinced this is a bug. Here's the web archive for listbox from 2022 that clearly shows we've had the ellipses:

For this to be considered a true bug, we would have to have the specifications clearly showing something clearly different from implementation from the time period before the implementation happened.

Design may simply not have considered this use case.

We do have an agenda item with design to revisit ellipses usage - either eliminate or reduce, but even that change would be a feature change, not a bug.

agliga commented 10 months ago

Fixed by duplicate bug https://github.com/eBay/skin/issues/2228