eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
178 stars 67 forks source link

ebay-toggle-button--with-image: Without fill placement option images in the ebay toggle button extending outside of the toggle button #2241

Closed mymadhu closed 6 months ago

mymadhu commented 8 months ago

I verified there's no existing issue for this bug.

Current behavior

(link removed)

Expected behavior

When fill placement option is used image displayed in img tag should not be cut off at the bottom in chrome

Skin version

ebay-skin 16.7.1

Device/OS/Browser info

Safari, Chrome image

Steps to reproduce

No response

Relevant code block

https://github.corp.ebay.com/adplatform/adsunified/blob/master/src/components/campaign-type/index.marko#L25

Additional context

image

Above images in safari(left) vs chrome(right) without using fillplacement option for ebay-toggle-button--with-image

image

Above image when fillplacement is used image is cut off in chrome

HimanshuDTU18 commented 8 months ago

@mymadhu can i attempt?

ArtBlue commented 7 months ago

@mymadhu , please do NOT post internal links!! This is an open-source project.