Venmo icon: Missing borders

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

https://ebay.github.io/skin/

MIT License

178 stars 67 forks source link

Venmo icon: Missing borders #2265

Closed HenriqueLimas closed 8 months ago

HenriqueLimas commented 8 months ago

I verified there's no existing issue for this bug.

[X] There are no existing issues

Current behavior

Venmo doesn't have border as the other payment methods

Expected behavior

Expectation is that Venmo icon has borders in it

Skin version

Device/OS/Browser info

No response

Steps to reproduce

Check Venmo icon on https://opensource.ebay.com/skin/#icon

Relevant code block

No response

Additional context

No response

ArtBlue commented 8 months ago

The icon we originally got was likely missing stroke-width on the rect. The other similar ones that do have the outline visually do have the stroke-width; this one icon does not.

To fix this, we simply need to add stroke-width="1" to the rect to look like this:

<rect x=".5" y=".5" width="49" height="31" rx="1.5" fill="#fff" stroke="#000" stroke-width="1"></rect>

ratinsl commented 8 months ago

@ArtBlue Here is the zip drive with the venmo assets with the stroke. 240207_venmo_stroke_assets.zip

ArtBlue commented 8 months ago

Thanks, @ratinsl !

ArtBlue commented 8 months ago

@ratinsl , I downloaded your zip file, and it looks like the stroke-width is still missing from the rect. Maybe whatever export issue caused this, caused the original exclusion?

ratinsl commented 8 months ago

@ArtBlue updated package with stroke-width added to all. Please test these. 240214_venmo_stroke_assets.zip