search

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
178 stars 67 forks source link

lightbox dialog: Title should wrap instead of using ellipses #2333

Closed LuLaValva closed 5 months ago

LuLaValva commented 5 months ago

I verified there's no existing issue for this bug.

Current behavior

Text in the title of lightbox dialog is truncated with ellipses instead of wrapping

Expected behavior

Title text should wrap

Skin version

17.4.1

Device/OS/Browser info

All devices & browsers

Steps to reproduce

Create lightbox dialog with header longer than screen width

Relevant code block

No response

Additional context

Text wrap was the initial behavior for this component, but there was a push from design systems team to truncate with ellipses instead. This should not have been approved because, especially after internationalization, there are likely to be cases where the title is impossible to read for some users.

Even in the worst case with text wrapping, the body will still be visible:

image

https://github.com/eBay/skin/assets/26027232/3ada6517-fda4-492d-928a-3d27859b1e00

As such, title should be reverted back from truncation to wrapping.

randybascue commented 5 months ago

Agreed. Let's revert to wrapping. We'll update on our end as well

ArtBlue commented 5 months ago

Excellent! Thanks, @randybascue !