Documentation: add a CDN link? - Githubissues

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

https://ebay.github.io/skin/

MIT License

178 stars 67 forks source link

Documentation: add a CDN link? #2354

Closed darkwebdev closed 4 months ago

darkwebdev commented 4 months ago

Description

Hey guys, I know you've removed a CDN link cause you probably didn't want to upload every version manually. But there's https://www.jsdelivr.com/package/npm/@ebay/skin that hosts Skin anyway: https://cdn.jsdelivr.net/npm/@ebay/skin@17.5.0/index.min.js https://cdn.jsdelivr.net/npm/@ebay/skin@17.5.0/dist/button/button.min.css

Does it make sense to add a section on how to use Skin without a bundler, maybe for simple websites that devs create to try Skin out?

Screenshots

No response

Figma link

No response

Engineering pre-requisites

[ ] Successful design review with Design System Team.
[ ] Supports dark mode.
[ ] Supports responsive design.
[ ] Tokens have been provided (or already exist).
[ ] Successful accessibility review with Core A11Y Team.
[ ] Successful frontend review with eBayUI Team.

agliga commented 4 months ago

Interesting However since we do not maintain that I don't want to add a dependency. If that stops being maintained then it will no longer work Also: we had toyed with the idea of hosting skin on a public CDN where we can automatically upload it when we publish. Closing issue for now. We can revisit if we want to add a public CDN link