Closed ratinsl closed 3 months ago
Hey @ratinsl , I noticed you filed this late last week. We had already done the planning for the next release and already have an icons issue (not started yet - https://github.com/eBay/skin/issues/2347) slated for next release. The Allipay icons are also included in that issue. To avoid confusion and get these updated into the next release as well, it might be best to reconcile these icons and move the changes from these two icons into that issue and we can just close this one.
Hey @ArtBlue, created a new ticket because I thought the other one had already been picked up, but that's great - I'll add these to the other one later today!
@ratinsl , maybe you're not seeing the statuses??? I know we've had this issue where you weren't seeing everything on the issue. Can you see this on the right side on https://github.com/eBay/skin/issues/2347 ?
Closing this ticket - added these items to the other open one. @ArtBlue I saw the part under "projects" but instead of "ToDo" I thought it was already assigned to a project which is why I created a new ticket. Will look out for this next time, thanks!
Closing this one - added these items to the other open one. @ArtBlue I saw the part under "projects" but instead of "ToDo" I thought it was already assigned to a project which is why I created a new ticket.
Np, @ratinsl . It is assigned to a project. The project is eBayUI, but the status field is a finer grained indication of status. With the exception of when we forget to move issues properly along the dev cycle, those should reflect the current status of the actual dev work.
Description
We have some icon additions and updates. There are some payment card icons here, and the stroke-width line was added to them. The alipay cn icon from the last batch had the incorrect blue color.
Web skin name mapping doc has been updated with the below items.
[New icons]
[Updated icons]
Thank you, and let me know if you have any questions, Ryan
242724_Web_Icons.zip
Screenshots
No response
Figma link
No response
Engineering pre-requisites