search

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
178 stars 67 forks source link

signal: text overflow does not truncate with ellipsis #2380

Closed mkchang closed 1 month ago

mkchang commented 2 months ago

I verified there's no existing issue for this bug.

Current behavior

Longer text in a signal does not truncate into ellipsis image

Expected behavior

Expected truncation per DS specs: image

Skin version

18.0.4

Device/OS/Browser info

MacOS + Chrome 126.0.6478.127

Steps to reproduce

1. Using ebayui-core/ebay-signal, inserted text that was longer than the allotted space for the signal.
2. See text wrap instead of truncate.

Relevant code block

No response

Additional context

No response

ArtBlue commented 1 month ago

The Signal component in Figma is v1.2. What's implemented in Skin is 1.0. It means we have not implemented this yet. We've actually not had discussions with DS about it either, and, at first glance, this doesn't appear to be an ideal solve. We have a few questions that we will need to have alignment over.

ArtBlue commented 1 month ago

After discussing this in WF, we're closing this issue. If DS wants to later implement this change, we can have those discussions then.