feat(button): add icon only option for small screens

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

https://ebay.github.io/skin/

MIT License

179 stars 67 forks source link

feat(button): add icon only option for small screens #2385

Open namtheho opened 4 months ago

namtheho commented 4 months ago

Description

For Button module, add an icon only option for small screens.

Engineering pre-requisites

[ ] Successful design review with Design System Team.
[ ] Supports dark mode.
[ ] Supports responsive design.
[ ] Tokens have been provided (or already exist).
[ ] Successful accessibility review with Core A11Y Team.
[ ] Successful frontend review with eBayUI Team.

agliga commented 1 month ago

This is only for trailing icon, the code for turning this into an icon only button will come later

ArtBlue commented 4 weeks ago

@namtheho , I cannot tag Randy for some reason. The Figma links are not pointing to a trailing button icon. Can we have the actual specs?

randybascue commented 4 weeks ago

@ArtBlue Weird that it's doing this again. Here are the specs

ArtBlue commented 3 weeks ago

I removed a comment with an image of the button specs that did not include a trailing icon.

ArtBlue commented 3 weeks ago

I updated this issue to target button as cta-button is an <a> and cannot have the use case (down chevron for lists) attached to the design specs.

ArtBlue commented 3 weeks ago

@randybascue , @namtheho , so we actually already have a trailing icon option in Button. Given this, I'm simply repurposing this issue to implement the addition of the icon only option responsively on small screens/container. I'm blocking it for design since we need the specs.