Item tile: EEK icon size

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.

https://ebay.github.io/skin/

MIT License

179 stars 67 forks source link

Item tile: EEK icon size #2447

Closed fwg001 closed 1 month ago

fwg001 commented 2 months ago

Description

Item Tile component displays the Eek icon at a different size from the DS spec. The design system spec shows 24px height for Eek Icon whereas Skin sets its height to 28px. Please update skin to 24px.

Screenshots

Figma link

https://www.figma.com/design/zEBdEhbonrBOGzZ0fXzWvM/eBay-Design-System?node-id=127302-223990&m=dev

Engineering pre-requisites

[X] Supports dark mode.
[X] Supports responsive design.
[X] Tokens have been provided (or already exist).

agliga commented 2 months ago

We need the svg asset for the outline arrow in order to fix this.

agliga commented 2 months ago

This is the asset we have from design. Its 28px viewbox height.

https://github.com/eBay/skin/blob/master/src/svg/icon/icon-eek-arrow.svg

agliga commented 2 months ago

This also could be a possible breaking change since we are changing the height and need the icon to be swapped out.

ratinsl commented 2 months ago

@agliga try this 24px asset out. The original asset looked pretty chopped up on the corners. I adjusted everything to not be chopped off. Let me know how it looks or if I need to make any more adjustments.

icon-eek-arrow.svg.zip

agliga commented 2 months ago

Will be breaking. Will need to add a variant to show smaller size.