eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
178 stars 67 forks source link

docs: update modules' Design System component mapping metadata #2486

Open cordeliadillon opened 18 hours ago

cordeliadillon commented 18 hours ago

Description

Update the component mapping metadata at the bottom of the following skin modules' .marko files to ensure that we are passing accurate information about component availability to our Component Status API. This API powers the cross-platform availability tables in our broader design system documentation.

Requested changes:

skin module ds-component mapping comments
button cta-button change from generic "button"
calendar date-picker
chart-legend graph
combobox combobox
confirm-dialog dialog
cta-button cta-button
field input
floating-label input
inline-notice inline-notice change from generic "alert-notice"
lightbox-dialog dialog remove "bottom-sheet"
link-fake link-button
page-notice page-notice change from generic "alert-notice"
section-notice section-notice change from generic "alert-notice"
select select change from "dropdown"
textbox add "password" to list of mappings

Also check DS version numbers of the following modules as they seem quite different from what's in our design system.

Screenshots

No response

Figma link

No response

Engineering pre-requisites

LuLaValva commented 18 hours ago

Skin actually splits date-picker into two different components; calendar and date-textbox. I see you have multiple skin modules mapped to input, can you do the same for date-picker?