search

eBay / skin

Pure CSS framework designed & developed by eBay for a branded, e-commerce marketplace.
https://ebay.github.io/skin/
MIT License
178 stars 67 forks source link

Checkbox: Change the default checked color according for DS6 #267

Closed sharma46bhawana closed 6 years ago

sharma46bhawana commented 6 years ago

Hi!

According to the https://ebay.invisionapp.com/share/4RDSWVN2D#/309035237_Controls, the default checkboxes when checked, have a fill color of blue instead of black (which is currently in skin).

Screenshot

screen shot 2018-07-16 at 4 39 14 pm

ianmcburnie commented 6 years ago

Hmm, this looks like DS4 not DS6. Will try and confirm with design team.

seangates commented 6 years ago

@ianmcburnie That screen shot came from design. :wink:

ianmcburnie commented 6 years ago

Yep, it's from Invision. But I don't know if this an "update" to DS4 or DS6. Or both. Need to confirm.

seangates commented 6 years ago

Checked state for DS4 is blue. Checked state (currently) for DS6 is black. Design wants DS6 checked state to be blue.

ianmcburnie commented 6 years ago

Where did you hear this?

seangates commented 6 years ago

Conversations with them yesterday, along with @sharma46bhawana. She and I spoke with Greg.

ianmcburnie commented 6 years ago

Okay. I wasn't made aware of that. Please put such information in the ticket from now on to avoid churn. There are lot's of invision links and screenshots flying around at the moment, and lot's of churn in general to distract us. I expect we'll see more such potential updates rolling in, but nothing's official until it's official. Let's try and fix our offline process for that and in the meantime we'll keep our focus on the retrofit as that remains #1 priority.

msendlakowski commented 6 years ago

Based on the latest design system requirements the blue color is a go. Fixed in v6.