Closed ianmcburnie closed 5 years ago
Going to work on a 6.3.5 patch for this issue. I may have to remove the concept of "common" and just keep background and foreground completely separate.
You could still keep the common stuff, but have it be part of the LESS import, and not part of the Lasso bundling.
Right, but in the dist css, there would be no concept of shared/common css for the icon widths and heights. Both background.css and foreground.css would include all of that (which is what I was trying to originally avoid). I don't think it's a big deal though, and solves this problem for now in a backwards compatible way.
Shame Lasso doesn't have a "don't dedupe this module" ability...or does it? That would be a quick and dirty fix for this, until I could refactor properly in 7.0.0. @DylanPiercey ?
Assuming not, I'm going to do this as a two part fix:
Here is the current browser.json for
@ebay/skin/icon
:NOTE: In 7.0.0 we are removing iconfont.
Here is
@ebay/skin/icon/background
:Here is
@ebay/skin/icon/foreground
:The lasso resolution will go:
Users of background icons will be fine, but specific foreground icons will have their width and height trumped due to base foreground.css rules coming after common.css.
This is therefore a regression for users of foreground icons.