eBay / tsv-utils

eBay's TSV Utilities: Command line tools for large, tabular data files. Filtering, statistics, sampling, joins and more.
https://ebay.github.io/tsv-utils/
Boost Software License 1.0
1.42k stars 80 forks source link

Switch to rawWrite for output. #314

Closed jondegenhardt closed 3 years ago

jondegenhardt commented 3 years ago

Switch BufferedOutputRange to use File.rawWrite rather than File.write when writing to file. This has two effects:

Regarding Windows newlines - Window is not currently supported, but it is worthwhile moving Windows support forward. A newline policy on Windows is TBD, but writing Unix newlines is an improvement, as it would enable the tools to work with each other in pipelines, and it gets closer to having a working Windows test suite. Updates to Windows newline handling can occur after that. See Issue #310.

codecov-commenter commented 3 years ago

Codecov Report

Merging #314 into master will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          18       18           
  Lines        6970     6970           
=======================================
  Hits         6926     6926           
  Misses         44       44           
Impacted Files Coverage Δ
common/src/tsv_utils/common/utils.d 100.00% <100.00%> (ø)