Most of the tsv-utils tools require Unix newlines. These tools check for Windows newlines on Posix platforms using throwIfWindowsNewlineOnUnix. However, these tools generally have trouble with Windows newlines on Windows platforms as well. And, there is no warning to users. This adds detection and user messaging on Windows.
The PR changes Windows newline detection to occur on all platforms. The throwIfWindowsNewlineOnUnix was renamed to throwIfWindowsNewline and the code changed to throw on all all platforms. Callers were changed to call the new function.
This is a step towards getting a Window build that has a fully functioning test suite. See issue #317. Support for Windows newlines can be evaluated after having a fully functioning test suite on Windows.
Most of the tsv-utils tools require Unix newlines. These tools check for Windows newlines on Posix platforms using
throwIfWindowsNewlineOnUnix. However, these tools generally have trouble with Windows newlines on Windows platforms as well. And, there is no warning to users. This adds detection and user messaging on Windows.The PR changes Windows newline detection to occur on all platforms. The
throwIfWindowsNewlineOnUnixwas renamed tothrowIfWindowsNewlineand the code changed to throw on all all platforms. Callers were changed to call the new function.This is a step towards getting a Window build that has a fully functioning test suite. See issue #317. Support for Windows newlines can be evaluated after having a fully functioning test suite on Windows.