search

eBayClassifiedsGroup / marathon_deploy

Pushes a yaml or json file to the Marathon API
MIT License
42 stars 14 forks source link

bin command line utitlity should be unique (it was deploy.rb) #1

Closed j1n6 closed 9 years ago

j1n6 commented 9 years ago

I suggest to rename the deploy.rb to the same name as the gem. This way I can execute marathon_deploy as command line tool instead of deploy.rb(a bit misleading)

j1n6 commented 9 years ago

Just tested locally, seems to work well

sielaq commented 9 years ago

can you also remove from other scripts .rb extension so it will be more consistent ?

j1n6 commented 9 years ago

Will do. Thanks.

Sent from my iPhone

On 27 May 2015, at 07:29, Wojciech Sielski notifications@github.com wrote:

can you also remove from other script .rb extension so it will be more consistent ?

— Reply to this email directly or view it on GitHub.

joncolby commented 9 years ago

I agree. thanks for the suggestion and patch!

j1n6 commented 9 years ago

I had a look at the other two rb script, I think they should be a command line option for the marathon_deploy command, and those two files should be internal libs out side the bin directory.

joncolby commented 9 years ago

Hi Jim,

I would agree that one executable would probably be cleaner (and is probably the Ruby gem standard way). My motivation was to keep the main executable simple for the end user to understand and use. The other helper scripts are used in our build pipeline already.

I’ll keep your suggestion in mind as we develop the tool further. Pretty swamped at the moment though.

On 27 May 2015, at 11:46, Jing Dong notifications@github.com wrote:

I had a look at the other two rb script, I think they should be a command line option for the marathon_deploy command, and those two files should be internal libs out side the bin directory.

— Reply to this email directly or view it on GitHub.

j1n6 commented 9 years ago

Totally understood your concern. I was going to develop similar tool for our company, glad you have done the work for us!