eBayClassifiedsGroup / update-ts-references

Helper for multi-package repository with TypeScript
MIT License
46 stars 6 forks source link

Does not return nonzero exit code when failed to read a tsconfig #41

Open dimikot opened 1 month ago

dimikot commented 1 month ago

Here: https://github.com/eBayClassifiedsGroup/update-ts-references/blob/4a7a93db2a19e5c698ed6cc6e6465bdc851a89b7/src/update-ts-references.js#L219

The exception is logged, but not rethrown. So the process exit successfully, which means that it's hard to use the tool in e.g. postinstall scripts or in CI.

In the example below, I manually deleted ./tsconfig.json and ran the tool as update-ts-references && echo ok - it printed "ok".

CleanShot 2024-10-04 at 00 39 56@2x

MKruschke commented 1 month ago

Hi @dimikot, if you or your teammates deleting the tsconfig.json from the root then I think my tool should be the least problem for you. Because your ts check isn't working anymore 😄

Anyway nice catch for improvement! I will add that check for the root tsconfig 👍🏻

Have a nice weekend 👋🏻