search

eBayClassifiedsGroup / update-ts-references

Helper for multi-package repository with TypeScript
MIT License
46 stars 6 forks source link

Improve cross OS setups #9

Closed Flarna closed 3 years ago

Flarna commented 3 years ago

I work in a project where some people use windows and others use linux.

node, typescript (and most other tools) work fine if unix style paths are used in e.g. tsconfig.json

This tool is currently modifying all our tsconfig.json files if executed on windows by replacing all / by \.

I think this could be easily fixed by adding .replace(/\\/g, '/') to the path.relative() results.

MKruschke commented 3 years ago

Hi @Flarna, thank you for your input here, especially because we using this internally on unix systems only I wasn't aware of that.

PR #11 will address that issue and after that is merged and published it would be could awesome if you can double check it on your side.

Best Mirko

MKruschke commented 3 years ago

@Flarna v2.0.0 is published. Wish you also wonderful x-mas 🎄