eDonnes124 / Town-Of-Us-R

An Among Us mod containing a bunch of roles
GNU General Public License v3.0
345 stars 140 forks source link

Update to Among us 2023.7.11 #159

Closed JeanTheFungle closed 1 year ago

JeanTheFungle commented 1 year ago

hey @eDonnes124 i was worked on TOU to update to Latest version of Among us so there a few changes :

  1. Add Support Latest Verison ✔️

  2. Add Custom Annoncements ✔️

  3. Test it ✔️ all works sucess

i wish to merge this pull-request and Good Luck 😄

Contact Me in discord : jeanamongus

AlchlcDvl commented 1 year ago

ResolutionManager.ResolutionChanged.Invoke((float)Screen.width / Screen.height);

needs to be changed to

ResolutionManager.ResolutionChanged.Invoke((float)Screen.width / Screen.height, Screen.width, Screen.height, Screen.fullScreen);

for it to work, zooming will break if you comment those lines out

JeanTheFungle commented 1 year ago

ResolutionManager.ResolutionChanged.Invoke((float)Screen.width / Screen.height);

needs to be changed to

ResolutionManager.ResolutionChanged.Invoke((float)Screen.width / Screen.height, Screen.width, Screen.height, Screen.fullScreen);

for it to work, zooming will break if you comment those lines out

Thanks i will add it 😄

JeanTheFungle commented 1 year ago

@eDonnes124 when this pull get merged 😄

Liimiitz commented 1 year ago

Just tested the new dll file after building and can confirm it works
image image

JeanTheFungle commented 1 year ago

@Liimiitz Contact me in discord plz i have something to tell you discord : jeanamongus

whichtwix commented 1 year ago

btw likely wont be merged, the mod has been made comptaible already but other things are going on, the custom announcements may or may not be added after its closed

JeanTheFungle commented 1 year ago

btw likely wont be merged, the mod has been made comptaible already but other things are going on, the custom announcements may or may not be added after its closed

but why ? Custom Annoucement is very good idea and i add support for AU 2023.7.11

JeanTheFungle commented 1 year ago

I wante really join developement i have in stock many ideas that i can do it 😄

AlchlcDvl commented 1 year ago

well from my communications with mdb, they're fine with being only 2 devs so sadly there won't be any openings for now

whichtwix commented 1 year ago

if you have any ideas feel free to make them then make a pull request here, it may get seen and added

but why ? Custom Annoucement is very good idea and i add support for AU 2023.7.11

i meant there is chance of it being added

JeanTheFungle commented 1 year ago

hey @MyDragonBreath is something in this pull-request will be in next version of TOU ? and thanks 😄

MyDragonBreath commented 1 year ago

as a bit of constructive feedback - from a thing you may have overlooked regarding properly testing the transporter menu. there was an error that needed to be patched out with the set visible method. when i did it weeks ago i chose to

[HarmonyPatch(typeof(ChatController), nameof(ChatController.UpdateChatMode))]
    class chatModeUpdate
    {
        private static bool Prefix(ChatController __instance)
        {
            if (!PlayerControl.LocalPlayer.Is(RoleEnum.Transporter)) return true;
            return (__instance != Role.GetRole<Transporter>(PlayerControl.LocalPlayer).TransportList);
        }
    }
MyDragonBreath commented 1 year ago

please do not ghost ping donners (or myself for that matter). apologies, we both have lives beyond this and it takes a while to get around to everything.

we have long since finished porting, and are currently working on the next update. Thankyou for your effort.

if you change an asset file (arrow.png) please indicate why/(or that you've even done it).

the mod news may be merged, but i don't necessarily like the idea of having to hardcode each version in. If it is merged in later, it will most likely have to be in a json/resource file format from the embedded resources, or pulled from github at runtime - that being said the code will be taken into consideration regardless.

i will close this for now, but feel free to make a separate pr for modnews