Minor improvements - Githubissues

eDonnes124 / Town-Of-Us-R

An Among Us mod containing a bunch of roles

GNU General Public License v3.0

336 stars 136 forks source link

Minor improvements #191

Closed ItzLoonie closed 7 months ago

ItzLoonie commented 9 months ago

I have made minor improvements to certain elements.

Fully colored role screen
- The "Your role is" text and the text below the player is now colored with the player's role
Corrected faction screen
- The background fade is now colored based on the player's faction rather than the role
Role colored vent outlines
- The vent outlines are colored based on the player's role
Role colored kill button player outlines
- The outline around players for when a kill button is highlighting a player is now based on the player's role
Role sound for neutral roles
- The Shapeshifter role sound from the vanilla game now plays when getting a neutral role

Previews:

I changed the branch it uses so I can freely edit it without modifying this pull request

JeanTheFungle commented 8 months ago

it be seem good did you take from BTOU ?

AlchlcDvl commented 8 months ago

what is btou? and fyi most of the changes here are commonly used code so it's not only from a singular mod

JeanTheFungle commented 8 months ago

what is btou? and fyi most of the changes here are commonly used code so it's not only from a singular mod

btou is BetterTownOfUs it was in 2022/2021 you find more info here GoodLoss

AlchlcDvl commented 8 months ago

ah you mean vincent's version of tou? either way, the code for the vent outlines has been there in multiple mods so there isn't any proper source for it. btou probably wasn't the first either so needlessly saying "did you take this from x?" will do you no good

ItzLoonie commented 8 months ago

it be seem good did you take from BTOU ?

While @AlchlcDvl is right on there being multiple sources, this specific code I used comes from my own source code for a different mod (Town of Host Re-Edited).

The colored outline code, neutral intro sound code, and the neutral intro color code came from TOH-RE, but can also be found in other mods.

JeanTheFungle commented 8 months ago

it be seem good did you take from BTOU ?

While @AlchlcDvl is right on there being multiple sources, this specific code I used comes from my own source code for a different mod (Town of Host Re-Edited).

The colored outline code, neutral intro sound code, and the neutral intro color code came from TOH-RE, but can also be found in other mods.

ah i understand thx

MyDragonBreath commented 7 months ago

Merged in next release