eGovPDX / Council-Agenda-App

5 stars 0 forks source link

Selection arrow hidden by gray selection bars #43

Closed OscarGodson closed 13 years ago

OscarGodson commented 13 years ago

Here's a snap:
Bug Screenshot

A link to a specific agenda:
http://dev.portlandonline.com/councilagenda/#!/agenda/215

OscarGodson commented 13 years ago

Also, another issue is when there are no items:
screenshot

earenson commented 13 years ago

It looks as if this got fixed with previous CSS tweaking, but I did notice something odd... the arrow is being placed in the vertical center of the item DIV, but the "center" is thrown off in items that contain a header tag. For example:

Example

Can the header tag be safely moved outside of the item?

OscarGodson commented 13 years ago

Not really, i mean, it could but the current semantic DOM structure would be broken. Instead of:

Agenda
- Session
--- Session Location
--- Session Time
--- Item
----- Item Header
----- Item Number
----- Item Content
----- Item Disposition

It'd be:

Agenda
- Session
--- Session Location
--- Session Time
--- Item Header
--- Item
----- Item Number
----- Item Content
----- Item Disposition

I see this causing issues with styling and selecting later on. For example, if you wanted to do a drag and drop on an item you wouldn't be able to just do $('.item').draggable(). You'd have to set item to draggable and link the item header and stuff.

Maybe with some JS we can center it based on the height of the .item?

earenson commented 13 years ago

I'm going to play with that active marker a bit and see how it could be made more clear... we might be able to solve it through design!

On the semantic tip, if we have more than one event under Times Certain, for example, right now we have:

Agenda
- Session
--- Session Location
--- Session Time

--- Item
----- Item Header
----- Item Number
----- Item Content
----- Item Disposition

--- Item
----- Item Number
----- Item Content
----- Item Disposition

--- Item
----- Item Number
----- Item Content
----- Item Disposition

So only the first item in a series has a Header. But I do see the potential issue with draggability in the future...

OscarGodson commented 13 years ago

this seems to be fixed, right?

earenson commented 13 years ago

Roger that.