search

eHealthAfrica / data-models-deprecated

Validation for standard data models
Apache License 2.0
4 stars 8 forks source link

add a `lock` property to the callback schema #100

Closed danse closed 8 years ago

danse commented 8 years ago

This took more than expected, because i hit a bug on Z-Schema

emig commented 8 years ago

Fine, I suggest a name like copy for that function accepting an object as parameter, so we have var schemas = copy(originalSchemas) and is more explicit what is going on.

Up to your, for the rest LGTM , merge :+1:

danse commented 8 years ago

well, deepCopy is even more explicit than copy, right?

emig commented 8 years ago

Absolutely, then do we need the getSchemas one at all, since the originalSchemas variable is bound on the outer scope?

danse commented 8 years ago

okay i renamed as you suggested :+1:

emig commented 8 years ago

:rocket: